Fixes for 3-way comparison in tests_to_html.py #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krohmerNV I like the idea of this improvement, though in my local tests it seems to break the simpler two-way comparisons between GLSL and OSL:
|
|
I'll investigate, thanks! |
|
@krohmerNV Just bumping this thread, in case you have a chance to follow up on this proposal! |
|
thanks @jstone-lucasfilm, I need to make time for this in the next week |
krohmerNV
force-pushed
the
PR-fix-3-way-test-compare
branch
from
863a6bb
to
dfd38f1
Compare
|
@jstone-lucasfilm updated the default parameters of the script to behave like before. |
krohmerNV
force-pushed
the
PR-fix-3-way-test-compare
branch
from
dfd38f1
to
b418d52
Compare
krohmerNV
force-pushed
the
PR-fix-3-way-test-compare
branch
from
233edea
to
090491b
Compare
jstone-lucasfilm
approved these changes
Aug 24, 2024
|
Just as external validation of the PR, here are the latest GLSL/OSL render comparisons with these changes in place: |
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit e1c8cc2
into
AcademySoftwareFoundation:main
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to do a comparison between MDL 1.6, 1.7, and 1.8 and found two issues:
--inputdir1,--inputdir2, and--inputdir3