-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for 3-way comparison in tests_to_html.py #1416
Fixes for 3-way comparison in tests_to_html.py #1416
Conversation
@krohmerNV I like the idea of this improvement, though in my local tests it seems to break the simpler two-way comparisons between GLSL and OSL: |
I'll investigate, thanks! |
@krohmerNV Just bumping this thread, in case you have a chance to follow up on this proposal! |
thanks @jstone-lucasfilm, I need to make time for this in the next week |
863a6bb
to
dfd38f1
Compare
@jstone-lucasfilm updated the default parameters of the script to behave like before. |
dfd38f1
to
b418d52
Compare
233edea
to
090491b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these improvements, @krohmerNV!
Just as external validation of the PR, here are the latest GLSL/OSL render comparisons with these changes in place: |
e1c8cc2
into
AcademySoftwareFoundation:main
Tried to do a comparison between MDL 1.6, 1.7, and 1.8 and found two issues:
--inputdir1
,--inputdir2
, and--inputdir3